Pass transport metadata to event decoders - #1376
Draft
jwils wants to merge 1 commit into
Draft
Conversation
jwils
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Indexing event decoders currently receive only the message body. Formats that keep event metadata in SQS attributes cannot access those values.
What
Pass SQS message attributes to decoders that implement the optional
decode_with_metadata(payload, metadata:)capability. Existingdecode(payload)implementations keep their current behavior.How
Forward each attribute's
stringValue, including number attributes represented as strings. Supply an empty hash when attributes are absent. For S3-offloaded messages, pass the attributes alongside the fetched body.Risk
The new path applies only to decoders that implement the optional method. This does not add a protobuf runtime dependency or change the existing decoder interface.
Testing
No manual testing.
Bigger picture
Builds on #1284 and enables protobuf records whose event metadata lives in transport attributes. The protobuf decoder will follow separately.